seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Table & TableCell Components: Remove Table margin and add TableCell alignment prop #43

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This PR removes the margin around the Table component, since the margin was causing a horizontal scrollbar to appear in Course Planning. The margin was moved to the PageBody component instead. Also, the prop alignment was added to the TableCell component so that users can adjust how the content within the td is positioned (text-align is set to left, right, or center). The default value of the alignment prop is left.

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #117

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 into develop will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          222       228    +6     
  Branches        18        18           
=========================================
+ Hits           222       228    +6     
Impacted Files Coverage Δ
src/Tables/TableCell.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1c83d2...7434ce7. Read the comment docs.