seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Fix Typing for TableCell backgroundColor prop #46

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This PR addresses this error in the Course Planning app: image

Individual areas cannot be accessed without casting using ColorRange, which was a broader type than required. Instead of ColorRange as a type, I set the type for area to { [key: string]: string };

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #117

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into develop will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          230       230           
  Branches        18        18           
=========================================
  Hits           230       230           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0ffd5d...3f47b30. Read the comment docs.