search

seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Adjust Header component to work better with PageTitle #49

Closed rmainwork closed 4 years ago

rmainwork commented 4 years ago

A small tweak to the Header component to make it work better with PageTitle by re-aligning child components using align-items: baseline;. This, in turn means that things are vertically center aligned, rather than aligned to the bottom of the header.

Before:
image
image

After:
image
image

codecov[bot] commented 4 years ago

Codecov Report

Merging #49 into develop will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          244       244           
  Branches        19        19           
=========================================
  Hits           244       244
Impacted Files Coverage Δ
src/Layout/Header.tsx 100.00% <ø> (ø)
src/Theme/MarkOneTheme.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e023610...aff37e3. Read the comment docs.

rmainwork commented 4 years ago

Ah. Good to know. I guess that makes sense.