seas-computing / mark-one

A UI component library for building React Apps (in development)

https://seas-computing.github.io/mark-one/

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Text Input Component - Padding & Vertical Alignment Adjustments #52

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This adjusts the padding of the Text Input component so that there is left, top, and bottom padding within the input field per Vittorio's guidance. The vertical alignment was also adjusted so that the label text and input field text line up.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run eslint on the code
[ ] I have added JSDoc for all of my code (where applicable)
[ ] I have added tests to cover my changes.

Priority:

[x] Normal
[ ] High

Related Issues:

Addresses #175

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into develop will not change coverage by %. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          310       311    +1     
  Branches        27        27           
=========================================
+ Hits           310       311    +1

Impacted Files	Coverage Δ
src/Forms/Label.tsx	`100.00% <ø> (ø)`
src/Forms/TextInput.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d82bb9...1d0892f. Read the comment docs.

natalynyu commented 4 years ago

This is how the Text Input components look now -

Label position: POSITION.TOP

Label position: POSITION.LEFT

Vittorio2015 commented 4 years ago

@natalynyu , nice work on aligning the baseline! Thanks also to @jonseitz .

rmainwork commented 4 years ago

@natalynyu Actually, just before you do - it might be worth turning those padding values into variables rather than having the magic numbers in there.