search

seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Modal Footer #54

Closed jonseitz closed 4 years ago

jonseitz commented 4 years ago

Adds a Modal Footer component to the library, and integrates it into the Examples for the modal. Since the ModalFooter is just a styled-component wrapped in withTheme, I haven't added any tests for the component -- any tests would just be verifying that third-party libraries do what they're supposed to, and I don't think that's necessary for our needs. Happy to discuss further if you feel differently.

codecov[bot] commented 4 years ago

Codecov Report

Merging #54 into develop will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          343       343           
  Branches        33        33           
=========================================
  Hits           343       343

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b1dcc2...61ddcb0. Read the comment docs.