Closed jonseitz closed 4 years ago
Merging #55 into develop will not change coverage by
%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 30 +3
Lines 343 373 +30
Branches 33 37 +4
=========================================
+ Hits 343 373 +30
Impacted Files | Coverage Δ | |
---|---|---|
src/Headings/SectionHeading.tsx | 100.00% <100.00%> (ø) |
|
src/Headings/index.ts | 100.00% <100.00%> (ø) |
|
src/Modals/ModalHeader.tsx | 100.00% <100.00%> (ø) |
|
src/Buttons/index.ts | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 00989c5...8b08a44. Read the comment docs.
Adds a
<ModalHeader>
component as a follow on to #53 and #54. Adds a top bar to the modal, and renders anychildren
as title text and, optionally, adds a close button to the top-right corner.This PR did start to sprawl a little bit, as I added a generic
<SectionHeading>
component, which I've extended and modified for use within the<ModalHeader>
. I also had to address some weird styleguidist behaviors by upgrading the library to the newest version, which improves support for typescript and changes the default behavior to prefer default exports over named ones.