Closed jonseitz closed 4 years ago
Merging #60 into develop will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 358 358
Branches 40 40
=========================================
Hits 358 358
Impacted Files | Coverage Δ | |
---|---|---|
src/Tables/Table.tsx | 100.00% <ø> (ø) |
|
src/Tables/TableBody.tsx | 100.00% <ø> (ø) |
|
src/Tables/TableCell.tsx | 100.00% <ø> (ø) |
|
src/Tables/TableHead.tsx | 100.00% <ø> (ø) |
|
src/Tables/TableHeadingCell.tsx | 100.00% <ø> (ø) |
|
src/Tables/TableRow.tsx | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d6f2fd4...29c6917. Read the comment docs.
@rmainseas just highlighting this comment from commit 29c6917:
Upon further reflection, there's a good case for allowing both number
and string
here, for those times when the colSpan
value is coming from a computed value like:
<TableHeadingCell colSpan={columns.length}>Heading</TableHeadingCell>
I made a mistake in #59, leaving in imports from 'Theme' that should have been '../Theme'. I'm also changing the type for
rowSpan
andcolSpan
fromnumber
tostring
, since that's closer to how regular html would be written.With
number
the usage would have to be:While with
string
the usage would be: