seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Dropdown, TextInput, and Modal Components - Add Missing Props Needed for Faculty Admin Modals #64

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This PR adds missing properties needed to create the Faculty Admin modal.

Dropdown: disabled and required properties were added for form validation purposes. TextInput: required property was added for form validation purposes. Modal: aria-labelledBy property was added for accessibility purposes.

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #214

codecov[bot] commented 4 years ago

Codecov Report

Merging #64 into develop will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          388       397    +9     
  Branches        42        42           
=========================================
+ Hits           388       397    +9     
Impacted Files Coverage Δ
src/Buttons/BorderlessButton.tsx 100.00% <ø> (ø)
src/Buttons/Button.tsx 100.00% <ø> (ø)
src/Dropdown/Dropdown.tsx 100.00% <100.00%> (ø)
src/Forms/TextInput.tsx 100.00% <100.00%> (ø)
src/Modals/Modal.tsx 100.00% <100.00%> (ø)
src/Tables/TableCell.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14f4671...c29d078. Read the comment docs.