Closed natalynyu closed 4 years ago
Merging #64 into develop will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## develop #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 388 397 +9
Branches 42 42
=========================================
+ Hits 388 397 +9
Impacted Files | Coverage Δ | |
---|---|---|
src/Buttons/BorderlessButton.tsx | 100.00% <ø> (ø) |
|
src/Buttons/Button.tsx | 100.00% <ø> (ø) |
|
src/Dropdown/Dropdown.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/TextInput.tsx | 100.00% <100.00%> (ø) |
|
src/Modals/Modal.tsx | 100.00% <100.00%> (ø) |
|
src/Tables/TableCell.tsx | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 14f4671...c29d078. Read the comment docs.
This PR adds missing properties needed to create the Faculty Admin modal.
Dropdown
:disabled
andrequired
properties were added for form validation purposes.TextInput
:required
property was added for form validation purposes.Modal
:aria-labelledBy
property was added for accessibility purposes.Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Addresses #214