Closed natalynyu closed 4 years ago
Merging #72 into develop will decrease coverage by
1.32%
. The diff coverage is98.82%
.
@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
- Coverage 100.00% 98.67% -1.33%
===========================================
Files 34 41 +7
Lines 429 530 +101
Branches 50 98 +48
===========================================
+ Hits 429 523 +94
- Misses 0 4 +4
- Partials 0 3 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/Forms/RadioButton.tsx | 91.66% <91.66%> (ø) |
|
src/Buttons/BorderlessButton.tsx | 100.00% <100.00%> (ø) |
|
src/Buttons/Button.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/Checkbox.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/Dropdown.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/Fieldset.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/Label.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/TextInput.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/ValidationErrorMessage.tsx | 100.00% <100.00%> (ø) |
|
src/Forms/index.ts | 100.00% <100.00%> (ø) |
|
... and 39 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9592424...78434c9. Read the comment docs.
I reorganized the tests so that there is a describe block for each prop and removed tests that were not affected by that specific prop. (commit 78434c9).
LGTM. Approved.
This PR adds the
Checkbox
,RadioButton
, andFieldset
components. The styling is based off of Vittorio Bucchieri's recommendations. As a note, a fieldset is required to be used in conjunction with both checkboxes and radio buttons for accessibility reasons.Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Addresses #229