seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Solve for Modal Content Overflow #74

Closed natalynyu closed 3 years ago

natalynyu commented 3 years ago

This PR adds the CSS property overflow to the ModalBody so that if the modal contents are larger than the modal itself, the user will be able to scroll through the contents. I added the CSS property to the body instead of the overall modal component so that the title of the modal would be 'sticky' and could always be seen.

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #235

codecov[bot] commented 3 years ago

Codecov Report

Merging #74 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #74   +/-   ##
========================================
  Coverage    98.12%   98.12%           
========================================
  Files           41       41           
  Lines          480      480           
  Branches        87       87           
========================================
  Hits           471      471           
  Misses           5        5           
  Partials         4        4           
Impacted Files Coverage Δ
src/Modals/ModalBody.tsx 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b294781...2437447. Read the comment docs.

rmainwork commented 3 years ago

Approved.