seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Feature/224 add accessibility to the label #81

Closed farassadek closed 3 years ago

farassadek commented 3 years ago

This PR related to the course planner ticket https://github.com/seas-computing/course-planner/issues/224 Based on the conversion with Vittorio, the invisible label should be accessible by the screen reader. Therefore the dispaly: none in the Label component in mark-one should be replaced with this css found in this url https://accessibility.18f.gov/hidden-content/

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (1543ac0) into develop (4cabc64) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #81   +/-   ##
========================================
  Coverage    98.24%   98.24%           
========================================
  Files           42       42           
  Lines          513      514    +1     
  Branches        96       96           
========================================
+ Hits           504      505    +1     
  Misses           5        5           
  Partials         4        4           
Impacted Files Coverage Δ
src/Forms/InputLabel.tsx 97.22% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0bd058...1543ac0. Read the comment docs.