Closed natalynyu closed 3 years ago
Merging #83 (4cabc64) into develop (b6cafd3) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## develop #83 +/- ##
========================================
Coverage 98.24% 98.24%
========================================
Files 42 42
Lines 513 513
Branches 96 96
========================================
Hits 504 504
Misses 5 5
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
src/Buttons/BorderlessButton.tsx | 100.00% <100.00%> (ø) |
|
src/Buttons/Button.tsx | 100.00% <100.00%> (ø) |
|
src/Theme/index.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c50b6f...4cabc64. Read the comment docs.
After loading the new
mark one
version in Course Planner, I was not able to access theforwardRef
prop inBorderlessButton
. After discussing with J Seitz, we found that the issue was with the import statements. The paths in theButton
components for the MarkOneProps interface must be relative, and absolute paths break when you use the library in another project.Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Addresses #252