seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Add "required" property for TextInput, Dropdown, RadioButton, and Checkbox #84

Closed natalynyu closed 3 years ago

natalynyu commented 3 years ago

We decided to take advantage of the HTML required property to indicate required form fields in the course admin modal. This property had not been exposed previously. I assigned the value of isRequired to the required property of the TextInput, Dropdown, RadioButton, and Checkbox components.

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #229

codecov[bot] commented 3 years ago

Codecov Report

Merging #84 (0312178) into develop (0a2df14) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #84   +/-   ##
========================================
  Coverage    98.24%   98.24%           
========================================
  Files           42       42           
  Lines          514      514           
  Branches        96       96           
========================================
  Hits           505      505           
  Misses           5        5           
  Partials         4        4           
Impacted Files Coverage Δ
src/Forms/Checkbox.tsx 100.00% <ø> (ø)
src/Forms/Dropdown.tsx 100.00% <ø> (ø)
src/Forms/RadioButton.tsx 96.00% <ø> (ø)
src/Forms/TextInput.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9a59d7...0312178. Read the comment docs.

natalynyu commented 3 years ago

@jonseitz That's a good point, thank you. I added the required property to the other form field elements in 0312178.