seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

TableCell Text Styling #94

Closed natalynyu closed 3 years ago

natalynyu commented 3 years ago

This PR adds text styling to the contents within a table cell. The medium and negative text colors in the theme were updated per accessibility (color contrast) recommendations from Vittorio in ticket #300. I added an optional variant property to the TableCell so that users can use the VARIANT.MEDIUM (which we will use for "No Longer Active" faculty absence fields in Course Planner) styling and VARIANT.NEGATIVE (which we will use for other faculty absences that need attention in Course Planner) styling. If the user does not specify a variant, the text font-weight and color will default to the theme's base color and medium weight, which is how all table cells were styled originally before this ticket.

Describe your changes

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #300

natalynyu commented 3 years ago

@jonseitz sure thing! I updated the TableRow background and hover color through ce93c80.