search

seas-computing / react-boilerplate

Starting point for react-based projects at SEAS computing
0 stars 1 forks source link

Docker rewrite #4

Closed jonseitz closed 5 years ago

jonseitz commented 5 years ago

Continuing on seas-computing/course-planner#6.

This PR completely wipes out the Vagrant and Ansible setup in favor of a Docker-based development environment. This required changes to the the webpack configurations, which has been consolidated down into a single webpackfile.js that just handles the build process (the development server will be configured in a future PR). In the interest of further consolidating configurations, I've removed the mocha test-runner and replaced it with a .mocharc.js file (which probably should have been a separate PR. sorry!)

Note that you should be able to build the docker container successfully, but it will throw errors if you run it because the actual code in the src directory still needs to be updated (ditto on the tests)

jonseitz commented 5 years ago

No particular reason for the change to webpackfile.js from webpack.config.js, but they're both read automatically by the webpack-cli and I have a slight preference for the shorter form without the double dot syntax. I'd be open to changing to the more common form for the sake of consistency if you think that makes more sense. (If you like to watch people argue there's an old github issue about this).

I also made one additional change to docker-compose.yml, setting the mongo version to 3.6 for documentDB compatibility.

rmainwork commented 5 years ago

Fair enough, I didn't know that webpack could find webpackfile.js, so I was wondering if you were somehow using some other tool to compile it down to webpack.conf.js or something. I did see the other issue in my research before I commented about the above :laughing:. This looks good to me. Merge at will.