add Actions (openhab internal), rename old Actions to ThingActions

seaside1 / jrule

openHAB Java Rules Engine

Eclipse Public License 2.0

29 stars 15 forks source link

add Actions (openhab internal), rename old Actions to ThingActions #208

Open querdenker2k opened 1 month ago

querdenker2k commented 1 month ago

This PR will

rename generated JRuleActions to JRuleThingActions
generate JRuleActions (based on all found ActionService's, e.g. Notifications from openhabcloud)

seime commented 1 month ago

At first glance, is it related to #204?

querdenker2k commented 1 month ago

oh damn, looks like. i saw your merge request, but never opened it and couldn't imagine what that meant based on the title. The approach is slightly different. I used ActionService and you used ActionType. Your's is still in progress? Can i try it?

seime commented 1 month ago

I forgot a bit about the pr myself, but I've been running it in production since this summer without issues. Ready for testing.

Not sure which approach is best, I'll need to read the code again to freshen my memory 😅.

jberggg commented 3 weeks ago

I'm running @seime 's changes for broadcast notifications through openhab "cloud". It works 👍🏽 Would be awesome if that feature makes it into the main branch. Thank you both for your work 🙏🏽