search

seaside1 / unifiprotect

openHAB UniFi Protect Addon
Eclipse Public License 2.0
22 stars 6 forks source link

Improvements #10

Closed lsiepel closed 1 year ago

lsiepel commented 1 year ago

Really like this binding. It is also popular in the marketplace :-)

Earlier i made a PR to improve the readme. Now that i use the binding for a day or so i had some unexpected memmory issues i never had before. Might not be related to this binding, but anyway i pulled the sources and did some code checking. The code looks code, but i also see some room for improvement. Today i spend some time to do some minor refactoring, added background scans. I think this benefits the overall code quality. Once i finish working i'll make a PR for that too if you are interested.

lsiepel commented 1 year ago

Gentle ping @seaside1

seaside1 commented 1 year ago

Sure why not. I opted out of background scan just to not have it running unless you really want it to, but then again background scanning is done in a lot of bindings. If you want background scanning and submit a PR for it, I will merge it as long as it is working ok. Any improvements to the code is more than welcome! BR S

seaside1 commented 1 year ago

Closing, feel free to submit a PR.