search

seasketch / next

A modernization version of the SeaSketch platform, released in 2022.
https://seasketch.org
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

Linked layers in reports appear to be universally broken #601

Closed wmcclin closed 1 year ago

wmcclin commented 1 year ago

I noticed that none of the maps linked in the Samoa project reports (seasketch.org/samoa) seem to be working. All are broken. Here's an example collection with reports: https://www.seasketch.org/samoa/app/forums/56/104#post-351

I checked and the same seems to be true for https://seasketch.org/fsm reports.

Screenshot 2023-05-18 at 1 10 36 PM
twelch commented 1 year ago

If all layers are not working, this sounds like a change on the SSN side or a lack of "legacy" layer Ids in SSN so that they still work

twelch commented 1 year ago

@wmcclin Layer switching works for FSM and Samoa in seasketch legacy. It looks like the geoprocessing reference ID's that are set in SSN for each layer don't match what is in the legacy project. I would guess that they were never set in SSN to match or they were set somehow to the wrong value. I don't think any change on the report side is needed here. The solution is on the SSN side, and it's to find the legacy layer ID for each layer and paste it into the geoprocessing reference ID field in SSN for each layer to make them match. Then the layer toggling should work.

I don't actually know an easy way to get the legacy layer ID, I always pull it out of the browser dev tools (second screenshot). I think Peter went through this process of making layer ID match in both SSN and legacy for azores or maybe others.

screenshot of ssn with wrong layer ID value, doesn't match the legacy ID

image

I don't a

image
wmcclin commented 1 year ago

Hmm. In the Samoa project, that makes sense. In the FSM project, however, all of the layers were working until yesterday, I think. We had them working during our meeting Pohnpei, for sure, and I frequently have used that project as a demo to show how reports work. I would have shown it a dozen times in Brazil when all of the links worked.

@twelch are you sure nothing would have changed in the reports in the last couple of days that could have broken those links?

twelch commented 1 year ago

@wmcclin these reports haven't been deployed anytime recently and the layer ids are hard coded in the report bundle. if legacy layer toggles still work in the reports then I think it points towards something changing or not being set in ssn.

Cc @underbluewaters

underbluewaters commented 1 year ago

Layer toggles were broken by some changes I made to support viewing more that one report at a time. Fix is here and being deployed right now.

I do notice that Samoa report ids haven't been set at all. The easiest way to update the SSN layer tree would be to copy IDs from the project's metrics.json file. FSM project IDs seem to match as expected.