search

seasonedcc / composable-functions

Types and functions to make composition easy and safe
MIT License
665 stars 14 forks source link

remove qs take 2 #85

Closed diogob closed 1 year ago

diogob commented 1 year ago

Another attempt at #84, it should also close #77.

Just trying a different approach for fun.

The previous attempt would still fail in some of the new test cases introduced here.

diogob commented 1 year ago

@danielweinmann please take a look at the test cases. Since this is going to be a breaking change let's ensure we cover all cases we care about.

gustavoguichard commented 1 year ago

@diogob I changed the base branch for this PR from main to v2

gustavoguichard commented 1 year ago

@diogob , let's get this merged? Can't stand qs anymore: https://bundlephobia.com/package/domain-functions@1.8.0

diogob commented 1 year ago

@danielweinmann @gustavoguichard I have rebased v2 and this branch on top of the new v2. I have also added a fancy new test case to cover several cases in the same call.