search

seasonedcc / remix-forms

The full-stack form library for Remix and React Router
https://remix-forms.seasoned.cc
MIT License
493 stars 25 forks source link

Fix flaky specs #153

Closed diogob closed 1 year ago

diogob commented 1 year ago

The expectation on the button disabled is failing under certain conditions even if the behaviour is working properly. Later we can reimplement those assertions using MutationObservers but that will be more work-intensive, so the current PR just removes the worst offender (the one in edit-value spec).

netlify[bot] commented 1 year ago

Deploy Preview for remix-forms ready!

Name Link
Latest commit cdb04e483b21594bb83126af54ee8e5b97cc1428
Latest deploy log https://app.netlify.com/sites/remix-forms/deploys/63e289542ea92f0008880ffc
Deploy Preview https://deploy-preview-153--remix-forms.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.