seatgeek / backstage-plugins

SeatGeek Backstage Plugins Collection
Apache License 2.0
34 stars 6 forks source link

Logger issue with plugin-slack-catalog-backend #71

Closed AndreaBacquele closed 1 month ago

AndreaBacquele commented 1 month ago

Hi! :hand: We are using your plugin-slack-catalog-backend We have a type error when we use fromConfig()in our backend module. With Backstage config in our createBackendModule, we use logger: coreServices.logger,.
But we have this type error: Argument of type 'LoggerService' is not assignable to parameter of type 'Logger'.

Would you happen to have a solution? We need to update our Backstage version to the 1.31 and they start to deprecate loggerToWinstonLogger method.

Thanks in advance

bbckr commented 1 month ago

Thanks for raising @AndreaBacquele. Opening a PR and will have the team review it once they are online.

AndreaBacquele commented 1 month ago

Thank you @bbckr 🤩

bbckr commented 1 month ago

Leaving reopened until the package is published, will be version 2.0.0

AndreaBacquele commented 1 month ago

Just to keep my team updated: Do you have an idea when the package will be published? :)

bbckr commented 1 month ago

Just to keep my team updated: Do you have an idea when the package will be published? :)

This was published yesterday https://github.com/seatgeek/backstage-plugins/releases/tag/%40seatgeek%2Fbackstage-plugin-slack-catalog-backend%402.0.0