search

seatgeek / fuzzywuzzy

Fuzzy String Matching in Python
http://chairnerd.seatgeek.com/fuzzywuzzy-fuzzy-string-matching-in-python/
GNU General Public License v2.0
9.23k stars 875 forks source link

Tone deaf package name? #218

Open einarbmag opened 6 years ago

einarbmag commented 6 years ago

Just checking, are the creators aware of the origin and meaning of the word fuzzy-wuzzy?

josegonzalez commented 6 years ago

When we first announced the package, I think the reference we had in mind was the "fuzzy wuzzy was a bear". Cute name for fuzzy string matching. Someone on HN said it was a pejorative in British culture, which we were unaware of, but the name sort of stuck.

I'm happy to rename to something better. The biggest issue is the package naming on pypi, not sure how to handle renames there - can we mark a package as deprecated/redirect?

Any help you can provide here would be great.

einarbmag commented 6 years ago

Yeah, I figured it was unintentional. I live in the UK and I wasn't aware of it either until I spoke about the package to my coworker who's a POC and he pointed it out.

I don't know what the best thing to do in this kind of situation is - probably as you say, you should change the name but alias the package with the old name so as not to break things for existing users. Maybe this can help : https://pypi.org/project/pypi-alias/, but I would contact pypi for guidance on how to do it seamlessly.

On Sat, Sep 29, 2018, 5:37 PM Jose Diaz-Gonzalez notifications@github.com wrote:

When we first announced the package, I think the reference we had in mind was the "fuzzy wuzzy was a bear". Cute name for fuzzy string matching. Someone on HN said it was a pejorative in British culture, which we were unaware of, but the name sort of stuck.

I'm happy to rename to something better. The biggest issue is the package naming on pypi, not sure how to handle renames there - can we mark a package as deprecated/redirect?

Any help you can provide here would be great.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seatgeek/fuzzywuzzy/issues/218#issuecomment-425662531, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2jEdfjaVf9o6-UVXNJuLJw2Ey5w3hZks5uf6_XgaJpZM4W-_Pc .

josegonzalez commented 6 years ago

Any ideas for naming?

einarbmag commented 6 years ago

Hot fuzz Fizzy match Fuzzy fizz

Will keep thinking and ask others

On Sat, Sep 29, 2018, 6:46 PM Jose Diaz-Gonzalez notifications@github.com wrote:

Any ideas for naming?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seatgeek/fuzzywuzzy/issues/218#issuecomment-425667215, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2jEWBlXDKXd6XUVR1b7rgWOLi_ZNh7ks5uf7_5gaJpZM4W-_Pc .

rickhanlonii commented 6 years ago

TIL

How about fuzzyfuzzy?

Eunoia commented 5 years ago

Fussy match:

(of a person) fastidious about one's needs or requirements; hard to please.

markdall commented 5 years ago

Yeek (See: "Little Fuzzy" by H. Beam Piper)

josegonzalez commented 5 years ago

If someone wants to make the requisite pull requests for this, I would gladly accept it.

freakboy3742 commented 5 years ago

@josegonzalez Happy to work up a PR for this - all I need is a decision on the preferred new name.

josegonzalez commented 5 years ago

fuzzy-string-match maybe?

Note: I no longer work at seatgeek, but can help coordinate changing the repository/making any necessary pipit changes, so long as someone walks me through it :)

einarbmag commented 5 years ago

Many good name proposals. I vote for fuzzyfuzzy as a minimal name change. fuzzy-string-match is to the point, but maybe a bit generic as there's other fuzzy matching packages out there?

josegonzalez commented 5 years ago

Can someone confirm fuzzyfuzzy also doesn't mean something odd?

songololo commented 5 years ago

fizzybuzzy!

gw00207 commented 5 years ago

this still needs to be changed!

Eunoia commented 5 years ago

fuzzyfuzzy should be ok. The Parry Gripp song, fuzzy fuzzy cute cute has 9.8 MM views, and no negative comments.

Urban dictionary doesn't have any thing negative to say about fuzzy fuzzy, just fuzzfuzz for what two friends named their secret handshake.

It should be culturally safe to rename the package. Caveat: I haven't asked anyone.

rickhanlonii commented 5 years ago

@josegonzalez @ekelleyv who has publish rights to make the rename happen?

acslater00 commented 5 years ago

FWIW I strongly do not think the package name should be changed. This package has 6000 followers on GitHub and numerous language ports, blog posts, stackoverflow answers, etc all under the original name. While I understand that the name has a negative connotation for some people, and that in hindsight a different name could have been chosen to avoid that, I think the ship has long since sailed on this.

If there is a way to alias the package for people who do not want to have to see the original package name in their repos, that would imo be a reasonable concession.

josegonzalez commented 5 years ago

I agree with @acslater00. Breaking installations at this point is kinda crappy - yes, I know existing installs won't be broken, but they won't get package updates anymore - but aliasing seems like a good compromise.

@rickhanlonii I no longer have access to any of this stuff - hurray off-boarding! - but the SG infra team should be able to facilitate any repository/pypi renaming, so long as someone figures out the exact steps that should be done so as not to "break" installs.

Zonr0 commented 4 years ago

Bit of an old bump, but just wanted to chime-in on this one. Big fan of this library but caught a good amount of egg on my face when someone pointed out the term's origins followed by some horrifying googling later.

Any update on the aliasing approach?

Drew-dot-A commented 3 years ago

Bumping again for the same reasons as @Zonr0

josegonzalez commented 3 years ago

This is being worked on internally.

For a bit more context, we have an internal RFC process at SeatGeek now. Folks file things, get feedback, and then do them (with help from the appropriate stakeholders/folks with keys to the kingdom).

Someone filed an RFC last week as to what to do here, taking into account future maintenance etc. The rename is something everyone agrees upon, and we're now at the point of figuring out the exact details (how things get released, what we'll do with various repositories, how redirects work, package naming, etc.). With the RFC, the actual change now has someone owning it, and we should be able to move relatively quickly.

I don't personally have a timeline on this, but the details are being sorted, so it should happen relatively soon.

edrandall commented 3 years ago

It's become important to get sorted sooner rather than later and not let it drag on. We simply can't use it as-is. Exact choice of name seems still open but personally I think "fuzzymatch" is clear and descriptive of exactly what it does.