search

seatgeek / fuzzywuzzy

Fuzzy String Matching in Python
http://chairnerd.seatgeek.com/fuzzywuzzy-fuzzy-string-matching-in-python/
GNU General Public License v2.0
9.21k stars 874 forks source link

Fix for Python 3.7 #243

Closed hb-alexbotello closed 4 years ago

hb-alexbotello commented 5 years ago

Fixes #233

According to PEP 479, if raise StopIteration occurs directly in a generator, simply replace it with return.

This is both backwards and forwards compatible code.

paulgoetze commented 4 years ago

@adrian-the-git, @josegonzalez @hb-alexbotello Thanks for fixing this. What is the state of this PR? I’d love to see the changes released, so that fuzzywuzzy works smoothly again with Python 3.7.

josegonzalez commented 4 years ago

I no longer work at SeatGeek and therefore have no commit rights (hurray offboarding!). Hopefully there is someone on the SG dev team that is reviewing PRs for OSS repositories, but it's not going to be me.

hb-alexbotello commented 4 years ago

Unfortunately, it seems no one has yet taken up the mantle in your place.

adrian-the-git commented 4 years ago

Is it time to fork this project?

paulgoetze commented 4 years ago

Hey @garetht, I saw you making some changes in SeatGeek’s Python repos recently. Maybe someone at SeatGeek could have a look again? Else I’d also be happy to get involved and help as a maintainer of fuzzywuzzy in the long run.

garetht commented 4 years ago

@hb-alexbotello thanks for the contribution! I'll try and contact the relevant people to get this published.

haykkh commented 4 years ago

Any updates on this @garetht? fuzzywuzzy seems to be entirely useless in a lot of use cases until this is fixed.

garetht commented 4 years ago

Ah sorry I'm going to try and ask for credentials again to publish this myself.

garetht commented 4 years ago

@haykkh @adrian-the-git @MariusMez 0.18 is now published