Fix window is not defined - Githubissues

seatgeek / react-infinite

A browser-ready efficient scrolling container based on UITableView

Other

2.71k stars 274 forks source link

Fix window is not defined #204

Closed titipakorn closed 7 years ago

titipakorn commented 7 years ago

The problem has occurred when it has been rendered from the server side.

This code can avoid the problem and work perfectly.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 93.991% when pulling 436d5d564f60d3d8d53676f5b5576188060dc1fd on titipakorn:master into e453e658e345bd20be00e119161da69d2bb33cf4 on seatgeek:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 93.991% when pulling 56daa481ab35f6fc94c54c92094ad1c83808d2e8 on titipakorn:master into e453e658e345bd20be00e119161da69d2bb33cf4 on seatgeek:master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 93.59% when pulling 143192f0975a91b84f31d830003d912a093bb37c on titipakorn:master into e453e658e345bd20be00e119161da69d2bb33cf4 on seatgeek:master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 93.59% when pulling db71c2b9b92fff72866bb91c41825c4fd3577ca4 on titipakorn:master into e453e658e345bd20be00e119161da69d2bb33cf4 on seatgeek:master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 93.59% when pulling f88e855c70743e8e34dea7802f75b4a329d657e4 on titipakorn:master into e453e658e345bd20be00e119161da69d2bb33cf4 on seatgeek:master.

mirzapourh commented 7 years ago

Hi,

Any ideas on when this would get merged?

Thanks

oogali commented 7 years ago

@titipakorn Why did you remove build/ from the Git ignore patterns, and then include a number of files that were previously meant to be excluded?

hack0001 commented 7 years ago

Having this problem on a server rendered application and was wondering if this fix will get merged?

garetht commented 7 years ago

@titipakorn thanks!

@hack0001 released as 0.11.1.