Added accessibility tags into control and removed nested containing div

seatgeek / react-infinite

A browser-ready efficient scrolling container based on UITableView

Other

2.71k stars 274 forks source link

Added accessibility tags into control and removed nested containing div #245

Open Jackleberry opened 7 years ago

Jackleberry commented 7 years ago

Added the following tags to the outer div for accessibility:

role="feed"
aria-setsize="-1"
aria-busy={this.state.isInfiniteLoading}

Remove the nested div (smoothScrollingWrapper) and moved infiniteScrollStyles to the outer div.

Fixed lint errors and tests.

Jackleberry commented 7 years ago

@garetht Would you be interested in merging this PR into the main codebase?

garetht commented 7 years ago

@Jackleberry sorry for the delay! This will be a breaking change that is incompatible with older versions so it will have to wait for an explicitly incompatible release.