seatgeek / react-infinite

A browser-ready efficient scrolling container based on UITableView
Other
2.71k stars 273 forks source link

Glitching empty area in window mode #249

Open sharpensteel opened 6 years ago

sharpensteel commented 6 years ago

In window mode, in page with header, state.displayIndexStart calculated incorrectly, which causes emply space before react-infinite items (see screenshot)

example files to reproduce bug: html + jsx

i created commit that fixesgetScrollTop / setScrollTop so they take into account y-offset of Infinite component on page

screenshot: image

bleshik commented 6 years ago

@sharpensteel could you please create a PR so that it gets merged? The lib works well, except this particular bug.

elnygren commented 6 years ago

any chance to get this into the codebase? This fix worked for me. 👍