search

seatgeek / react-infinite

A browser-ready efficient scrolling container based on UITableView
Other
2.71k stars 273 forks source link

upgraded peer dependencies to react 16.2.0 #268

Closed aaronincincy closed 6 years ago

aaronincincy commented 6 years ago

This updates peer dependencies to react 16.2.0 and fixes the failing unit tests preset in #240.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 90.741% when pulling c727ff4039868d3f008604630faf4dca2669d4ce on aaronincincy:upgrade-to-react-16 into 48182b46e7a64831aaca756d51a9e29fa4db1244 on seatgeek:master.

aaronincincy commented 6 years ago

I'm not sure what's going on with the failed CI build. I'll look at that when I get home this evening.

aaronincincy commented 6 years ago

@garetht I tried to look into this, but I'm struggling to even know what the error is. Can you provide any guidance on this?

aaronincincy commented 6 years ago

Ok, I did fix an issue on the examples pages and they're now behaving the same as the current version, however I'm still getting an issue with the CI build failing. I'm not really sure where to go from here.

mashehu commented 6 years ago

I think I found the problem with the build fail. It was using a deprecated version of cypress, see #269. But the test seems now to be failing because of outdated dependencies...

garetht commented 6 years ago

Thanks for the help @aaronincincy and @mashehu! I'll make a release later today.

NoelAramis commented 6 years ago

Could you please update the @latest in the NPM repository, so that the npm install pulls the latest version from github? Thanks.

jnarwold commented 6 years ago

Any update on when we might get a release for this?

schnubor commented 6 years ago

+1 on the release? asking for a friend... ahem.

garetht commented 6 years ago

Sorry for the delay - will do this later today.

garetht commented 6 years ago

@NoelAramis @jnarwold @schnubor This has been released as 0.13.0