search

seatgeek / react-infinite

A browser-ready efficient scrolling container based on UITableView
Other
2.71k stars 274 forks source link

Move `enzyme-adapter-react-16` to devDeps #276

Open Kerumen opened 6 years ago

Kerumen commented 6 years ago

enzyme-adapter-react-16 is only required for the tests, it shouldn't be included in the dependencies.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 90.741% when pulling 15f1edf6da2c343694583fd5146615e0b1bad7b4 on Kerumen:master into d4517c975b73629d647516071e0415af61ac4231 on seatgeek:master.

danalloway commented 6 years ago

LGTM

chrisvoll commented 6 years ago

@Kerumen thanks for the PR! Do you know why there were so many changes in package-lock.json? It should only contain { "dev": true } changes

Kerumen commented 6 years ago

@chrisvoll I don't know, I just moved the package and ran npm i.

Maybe npm changed his way to manage lock files since it has been generated. I have npm v6.2.0.

geminiyellow commented 6 years ago

hi @kgregory , why don't you merge this PR? please merge it and publish a new version.

kgregory commented 6 years ago

@geminiyellow I am not a maintainer

geminiyellow commented 6 years ago

opps, sorry @kgregory , you review and approve the PR, so think you are maintainer. and this library last merge is half year ago. is it still alive ? @garetht

kgregory commented 6 years ago

@geminiyellow I used this library in the past and was hopeful that it would be updated for React 16, but it doesn’t look good. I reviewed some issues and PRs to help out, but it doesn’t appear to have much support. Prove me wrong @garetht!