seatonjiang / gitmoji-vscode

Gitmoji tool for git commit messages in VSCode
https://marketplace.visualstudio.com/items?itemName=seatonjiang.gitmoji-vscode
MIT License
276 stars 29 forks source link

Selecting an emoji doesn't put focus on the right input field #20

Open YeapGuy opened 3 years ago

YeapGuy commented 3 years ago

As said in the title, after selecting a Gitmoji, the field of the first project is always focused on, regardless of which button was pressed. Would be nice if the cursor was put in the right commit message input box. https://user-images.githubusercontent.com/43749899/103943300-2079cd00-5132-11eb-9e59-bcfbcb4d8682.mp4

seatonjiang commented 3 years ago

Hi @YeapGuy , thanks for your feedback, i have reproduced the problem and am looking for a solution.

KaKi87 commented 2 years ago

Hello, any news on this ? Thanks

OneHoopyFrood commented 2 years ago

For me, the focus is not returned to the input at all, but to the "sync" button. Could that be fixed too, please?

OneHoopyFrood commented 2 years ago

:bump:

OneHoopyFrood commented 2 years ago

Actually, I refined this a bit. I wonder if it might actually be a VSCode bug. When I'm in the field and use a command to open gitmoji (so as not to use the mouse) then when the gitmoji is selected my focus is not returned to the input. However when I open gitmoji via command whilst the focus is on the editor window, then focus IS set to the commit message input. Very strange.

Is this something you can do something about, or is this VSCode? I'm not overly familiar with extension authoring.

huyz commented 1 year ago

There seem to be two independent problems: 1) The focus doesn't go back to the "Source Control" view after the gitmoji inserts the emoji. This could be a gitmoji-vscode issue. 2) VS Code seems to be confused about which input control inside the "Source Control" view should have focus when focus comes back to the view (from an editor). This could be a VS code issue.

For the second problem, whether the focus returns to the input field or not seems to depend on your history of focus within the "Source Control" view. In other words:

KaKi87 commented 4 months ago

Hello, Any news on this ? Thanks