search

seatonjiang / gitmoji-vscode

Gitmoji tool for git commit messages in VSCode
https://marketplace.visualstudio.com/items?itemName=seatonjiang.gitmoji-vscode
MIT License
277 stars 30 forks source link

After updating vscode, the icons have become smaller #23

Closed wyangx closed 3 years ago

wyangx commented 3 years ago

vscode version: 1.56.0 os: windows10

seatonjiang commented 3 years ago

I was unable to reproduce this issue.

image

KaitoHH commented 3 years ago

I have the same problem. It seems that this problem occurs when there are multiple submodules in one project, where the icon will be appearing at the sub-panel, not the source control panel. 未命名

seatonjiang commented 3 years ago

I suspect that this is not a problem with the extension, the icon here is written according to VSCode's guidance instructions (16px svg icon). I think it is necessary to retrieve the VSCode issues to see if there is a similar problem after the new version update

https://code.visualstudio.com/api/references/contribution-points#Command-icon-specifications

wyangx commented 3 years ago

The icon only gets smaller when there are multiple items Then I found this css is overriding the height of the icon to make it smaller

yi-Xu-0100 commented 3 years ago

https://github.com/microsoft/vscode/issues/123041

seatonjiang commented 3 years ago

Thanks to @yi-Xu-0100 for introducing the issues, this is indeed a VSCode problem, just wait for the new VSCode version to be updated. @KaitoHH @wy916787036

KaitoHH commented 3 years ago

FYI, the problem has been fixed in 1.56.2

image