search

seatonjiang / gitmoji-vscode

Gitmoji tool for git commit messages in VSCode
https://marketplace.visualstudio.com/items?itemName=seatonjiang.gitmoji-vscode
MIT License
277 stars 30 forks source link

feat: add Brazilian and European versions #40

Closed gusbemacbe closed 2 years ago

gusbemacbe commented 2 years ago

Good morning @seatonjiang !

Regarding @brunodantas's #38, Brazilian and European versions were added.

seatonjiang commented 2 years ago

Hi @gusbemacbe,Thanks for the PR, but I have to say that putting all the translated content in the gitmoji.ts file is not a good approach, we will find a way to improve it in the future by putting the translated files in a separate place.

gusbemacbe commented 2 years ago

@seatonjiang

I agree. Clean code is important.

You can check @Pkief's repo that has translations. Go to src/i18n folder:

https://github.com/PKief/vscode-material-icon-theme/tree/main