search

seatonjiang / gitmoji-vscode

Gitmoji tool for git commit messages in VSCode
https://marketplace.visualstudio.com/items?itemName=seatonjiang.gitmoji-vscode
MIT License
277 stars 30 forks source link

Gitmoji no longer working: Emojis are not put into commit message #46

Closed dbachran closed 1 year ago

dbachran commented 1 year ago

Haven't been using VS Code for a few weeks now (holidays and such), but I just noticed that Gitmoji does no longer insert any emojis into the commit message anymore. I am able to select the desired emoji, but when I click on it, nothing happens.

I am using VS Code both natively (with Windows Git repos) and in WSL. Gitmoji seems to be enabled (haven't changed anything here) and was working fine earlier in my setup.

Visual Studio Code

Version: 1.74.3 (user setup) Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534 Date: 2023-01-09T16:59:02.252Z (1 wk ago) Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0.19042 Sandboxed: No

E1337Kat commented 1 year ago

Just to check, because I had the same issue, and it turned out to be a non-issue, but in the extension host output, when trying to select an emoji, does it print out an error like 

2023-01-17 15:51:22.730 [error] TypeError: Cannot read properties of undefined (reading 'path')
    at /~/.vscode/extensions/vtrois.gitmoji-vscode-1.0.9/out/extension.js:48:73
    at Array.find (<anonymous>)
    at /~/.vscode/extensions/vtrois.gitmoji-vscode-1.0.9/out/extension.js:47:63
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

It seems that the original extension I used by this vtrois person does not exist anymore and when looking up the extension this was the first hit and seemingly the same thing (but with newer updates even).

The fix was simple, disable/uninstall the old extension and install this extension such that your extensions are like this: image

I guess the extension I used before was either a copy of this one and I didn't realize it, or this is a fork and the last person left VS code or something?? I dunno. it's just a bit weird.

dbachran commented 1 year ago

Thanks @E1337Kat, that seems to have been my issue as well! 👍

I had installed the Gitmoji extension from Vtrois. After uninstalling that and installing the Gitmoji extension from Seaton Jiang, everything is working fine now. Maybe the extension has been forked and/or the maintainer changed. 🤷 (I was pretty shure that there was no other Gitmoji extension back when I installed it -- sometime last year, or maybe even 2021 already...? 🤔)

Aynways, this issue can be closed.

ciao, daniel :-)