Closed herpaderpaldent closed 3 months ago
Added Reference to Character Info
The reference to CharacterInfo
model from the Eveapi
package is added in CharacterAffiliationJob.php
. This will allow the use of CharacterInfo
model functions inside our file.
New Methods in CharacterAffiliationJob.php
Three new methods are introduced. The getMissingIdsArrayFromCharacterInfo()
helps to get a list of IDs that are not available in CharacterInfo
. processAffiliations()
and throttleAndProcessAffiliations()
are used to manage and handle (in a controlled rate) the character affiliations respectively.
Improved executeJob()
Method
The executeJob()
method does its actions now using a match
expression, which is a clearer and more streamlined way to write out decision-making code than using multiple if
statements.
Renamed Methods
For clarity, we've renamed two methods in CharacterAffiliationJob.php
. Now, their names reflect that they return arrays, not individual items.
Updated updateOrCreateCharacterAffiliations()
Method
This method now accepts an array of character IDs instead of a collection, which makes the inputs more flexible and easier to handle.
Added Testing Components
In CharacterAffiliationLifeCycleTest.php
, several new references are added. These references are crucial for setting up our testing environment correctly. A new test case has been created to ensure the program behaves correctly when a CharacterInfo
object has no character_affilations
.
…rocess missing character infos