search

seattleflu / augur-build

the (in development) augur build for understanding influenza dynamics in Seattle
https://seattleflu.org
0 stars 2 forks source link

Optional Filtering-to-region #22

Closed miparedes closed 5 years ago

miparedes commented 5 years ago

This is in response to #18

I changed extract_cluster_fasta in order to make --metadata be an optional requirement and to allow it to take an additional optional parameter filter-to-region where defining a specific region via bash command will filter to only those clusters that contain at least one strain from that region. I was unsure if you wanted me to include filter-to-region as a params in the Snakefile so it's currently set up to be included as a bash command but I can change if needed.

TB edit: like this: Closes #18.

trvrb commented 5 years ago

Looks great. Thank you @miparedes!

trvrb commented 5 years ago

BTW if you use the magic words: "closes #18" in the PR description, merging this PR will automatically close its associated issue.