search

seattleflu / genomic-incidence-tracker

https://genomic-incidence-tracker.herokuapp.com
GNU Affero General Public License v3.0
1 stars 0 forks source link

Add incidence as a primary variable #13

Closed kairstenfay closed 5 years ago

kairstenfay commented 5 years ago

Previously, what we're calling "Incidence" (but is really just count of participants) was missing from the viz prototype. Add a temporary solution to make "Incidence" work with the existing viz.

I describe this commit as "temporary" because all these if/else and switch/case statements are red flags to me, signaling that the architecture of this app should be rewritten, perhaps in an OO-design.

I welcome thoughts and feedback on current & future design here.

jameshadfield commented 5 years ago

Thanks @kairstenfay 🎉 i'll take a look shortly

While it's in your memory, could you elaborate a bit more on what you had in mind for a more "OO-design"?

kairstenfay commented 5 years ago

I'm thinking an object oriented (OO) design using polymorphism or dependency injection. I don't have a lot of experience in OO programming, though, so we should also consult @tsibley.

On Mon, Jul 8, 2019, 6:38 PM james hadfield notifications@github.com wrote:

Thanks @kairstenfay https://github.com/kairstenfay 🎉 i'll take a look shortly

While it's in your memory, could you elaborate a bit more on what you had in mind for a more "OO-design"?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seattleflu/genomic-incidence-tracker/pull/13?email_source=notifications&email_token=ACW3NEFXISZWDNR7OIGQE7TP6PTYRA5CNFSM4H7AUD72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZO2COQ#issuecomment-509452602, or mute the thread https://github.com/notifications/unsubscribe-auth/ACW3NEFXX5M5NXEQ3OQ4TIDP6PTYRANCNFSM4H7AUD7Q .