seattleflu / genomic-incidence-tracker

https://genomic-incidence-tracker.herokuapp.com
GNU Affero General Public License v3.0
1 stars 0 forks source link

Make the table scroll when it's a lot of regions #6

Closed jotasolano closed 5 years ago

jotasolano commented 5 years ago

@jameshadfield This is an idea I had (we don't really have to implement it), but when we have a lot of regions (e.g. CRAs, Census Tracts) then the bars and labels get very compressed and hard to read. Instead, we could implement a d3.scaleBand() just like in the Observable sketch and set the content of the container div to scroll vertically.

If you run this branch you'll see the idea https://github.com/seattleflu/genomic-incidence-tracker/tree/expandable-container (I created this a couple of days ago so it's already behind the master branch)

jotasolano commented 5 years ago

If we do choose to go this way, we'll probably have to put the legend and axis in a separate div on top of the actual chart, so that the axis is always visible regardless of where you are scrolling

jameshadfield commented 5 years ago

I think the idea of internal scroll is great.

tsibley commented 5 years ago

Is this now taken care of by the recent merge to master?

jotasolano commented 5 years ago

@tsibley yes! Sorry, I completely forgot to close this issue. This was merged to master in https://github.com/seattleflu/genomic-incidence-tracker/pull/11. Closing this now