search

seattlerb / ruby_parser

ruby_parser is a ruby parser written in pure ruby. It outputs s-expressions which can be manipulated and converted back to ruby via the ruby2ruby gem.
http://www.zenspider.com/projects/ruby_parser.html
476 stars 100 forks source link

Create a GitHub Actions workflow to run tests #343

Closed torrocus closed 10 months ago

torrocus commented 10 months ago

We have to run tests locally. I added ability to run tests on GitHub CI.

Feedback

Checked on the local fork and everything works. :tada:

torrocus commented 10 months ago

@zenspider I think it's worth merging it before merging other PRs.

torrocus commented 10 months ago

@zenspider Take a look when you have some free time. I think this might be useful.

torrocus commented 10 months ago

Is there anything stopping you from merging this PR?

zenspider commented 10 months ago

calm down.

zenspider commented 10 months ago

Not gonna add. I don't want to use github any more than I have to. Besides, this project is (probably? hopefully?) being supplanted by prism in the future.

torrocus commented 10 months ago

Thank you @zenspider for your response, and I apologize if my previous comments seemed too persistent. I noticed that you are making other changes in this repository, leading me to believe that you might have overlooked this specific PR. I have good intentions and simply wanted to streamline the test running process.

I respect your approach to using GitHub, although it wasn't explicitly stated anywhere. My intentions were straightforward – I thought that incorporating these changes could automate the PR review process and encourage more collaboration on the project. Even if you are planning for "prism" to replace "ruby_parser" in the future, it's challenging to predict when that transition might occur.

Could you share the reason why all the PRs are closed without being merged? I see that some changes from PRs are in the master branch commits. However, none of the authors are included in the list of contributors. It's possible I'm missing something. I couldn't find an answer to this question, so I would appreciate a better understanding of the situation.