search

seattlerb / rubyinline

296 stars 41 forks source link

mingw 1.9 support #13

Closed rdp closed 12 years ago

rdp commented 12 years ago

My fork has some patches to support mingw 1.9 It's either use these or switch to using a "makefile" type build instead of calling gcc, I believe. Thanks. -roger

zenspider commented 12 years ago

@luislavena, can you take a look at this? I won't bother unless you give your seal of approval.

luislavena commented 12 years ago

Hello,

Actually the only thing that matters is .gsub(/\$\(.*\)/, '') to filter out some debugging options that are inside RbConfig::CONFIG["LDSHARED"]

On 1.9.2, this is what contains: "gcc -shared $(if $(filter-out -g -g0,-g),,-s)"

Which are Make logic.

The pull request contains other modifications that are already in place, so perhaps you want to rewrite the code to something like this:

ldshared = Config::CONFIG["LDSHARED"].gsub(/\$\(.*\)/, '')

cmd = [ ldshared,

There is no need to modify the command line further than this.

Cheers!

rdp commented 12 years ago

let me clean this up a bit...somehow the pull request came in weird, too.

rdp commented 12 years ago

@luislavena could you look at my next attempt at a pull request please? Thanks. https://github.com/seattlerb/rubyinline/pull/14