search

seattlerb / rubyinline

296 stars 41 forks source link

Bundler and ActiveSupport patches #7

Closed asm closed 13 years ago

asm commented 13 years ago

I've added bundler support using two files from opsb's fork at https://github.com/opsb/rubyinline.

I've also changed two requires to Kernel.require as require is overloaded by ActiveSupport (it attempts to read the contents of files being required to determine their constants). I'm aware of the workaround involving ActiveSupport::Dependencies.mechanism. Unfortunately, we rely on the default behavior.

drbrain commented 13 years ago

The gemspec won't be merged. Only released versions of RubyInline are supported, not random revisions from github.

Doesn't bundler download and install gems? Isn't releasing the gem on rubygems.org all that's needed to support bundler?

zenspider commented 13 years ago
  1. I won't commit a generated file to my repository. It isn't dry.
  2. This is addressing a bug in activesupport's require. Have you filed a bug on rails?
asm commented 13 years ago

I'm under the impression it's standard practice to include Gemfile and .gemspec with your gem/repo.

I haven't filed a bug with Rails. While I agree this is a bug with Rail's autoloader, I can't think of a good workaround other that what's include with this patch.

zenspider commented 13 years ago
  1. Just because it is a standard practice doesn't mean it is a good one or that I accept it. Again, only released versions of RubyInline are supported.
  2. You can't think of a good workaround ... do you think that anyone else might be? Do you think that they can if you don't file a ticket? They won't know about the problem if you don't file a ticket...

This is not a bug in inline. It is a bug in rubygems.