search

seattlerb / zentest

144 stars 72 forks source link

Add instance variable failed_examples_count. #50

Closed gspilio closed 11 years ago

gspilio commented 11 years ago

You can use it in conjuction with :red hook to update your terminal title with the number of failed examples.

gspilio commented 11 years ago

Sorry for the late reply but i just saw this. As it happens I made a mistake and committed a previous revision. The one that should have been committed obviously drops the printing of self.failed_examples_count, improves the setting of failed_examples_count with some checks (failed.empty?) and resets the failed_examples_count at the start of run_tests. But i don't think it makes any sense to push any updates now since I am failing to understand if the "no" goes to the feature or its' implementation. If it's the implementation would you like to add some pointers as to what I did wrong?

zenspider commented 11 years ago

The comments I left were on specific lines.

gspilio commented 11 years ago

Obviously i have no idea what the context for the no in a blank line was, but hopefully this two commits will satisfy you.

zenspider commented 11 years ago

Where is the test showing this works?

zenspider commented 11 years ago

Did you run the tests?

gspilio commented 11 years ago

Thank you for your time zenspider, i think i will close it for now.