seattlerb / zentest

144 stars 72 forks source link

Fix: let autotest trigger on new files after the first run #59

Closed keroami closed 10 years ago

keroami commented 10 years ago

autotest would not detect any new file after the first run; very annoying when doing coding katas, still annoying on other projects.

Writing a test would be hard, since I'd have to either mock Find.find, or actually create files. Trying to extract Find.find (so I could test the remainder, but also replace it with e.g. rbinotify) is even harder, since a lot more happens than just finding files:

I would change a lot if I were to refactor that code. Which is not worth it for the bugfix by itself; but also not sensible without discussing beforehand. So. No test.

Hope you still merge.

Bye, Kero.

zenspider commented 10 years ago

This seems OK to me, but can you apply and send the PR against https://github.com/seattlerb/minitest-autotest instead?

zenspider commented 10 years ago

This is merged into minitest-autotest. Thanks!