search

seaweedfs / seaweedfs-csi-driver

SeaweedFS CSI Driver https://github.com/seaweedfs/seaweedfs
Apache License 2.0
220 stars 50 forks source link

Use helm YAML from seaweedfs repo #112

Closed Jackbennett closed 1 year ago

Jackbennett commented 1 year ago

Publish the helm chart via github pages, with a simple CI lint of the chart on PR.

Thanks to @washcycle as I just lifted their seaweedfs at https://github.com/seaweedfs/seaweedfs/pull/4243

Updated the paths and tested on my fork so far as proving it works. You might want to update the Chart.yaml appVersion: latest to a number, not sure how you want to handle this.

Required setup by maintainer for gh-pages branch to exist before the release workflow can complete;

git switch --orphan gh-pages
git commit --allow-empty -m "Initial Commit for Helm Releases"
git push origin gh-pages
chrislusf commented 1 year ago

Merged and set up gh-pages branch.

Let me know how to test it is working.

washcycle commented 1 year ago

@Jackbennett thanks this was on my long list of to-dos, glad someone jumped in. Open source working as intended. Cheers!

washcycle commented 1 year ago

@chrislusf can add this helm chart to the seaweedfs artifact hub after this.

Jackbennett commented 1 year ago

Merged and set up gh-pages branch.

Let me know how to test it is working.

With gh-pages existing you should just have to make a tag. You'll have to make a new version I think.

There's quite a few changes between this and 1.1.2 in master so moving the tag and re-pushing 1.1.2 now that this workflow exists.

If you want to try republishing 1.1.2 before minting a new version then I think you make a "release" branch from 1.1.2, cherry-pick these commit and move the 1.1.2 tag.

Once the workflow completes you can check https://seaweedfs.github.io/seaweedfs-csi-driver/helm/index.yaml should render some yaml pointing to the tar.gz of the chart which the helmcli with read with helm repo add etc.