Swarm csi - Githubissues

seaweedfs / seaweedfs-csi-driver

SeaweedFS CSI Driver https://github.com/seaweedfs/seaweedfs

Apache License 2.0

210 stars 50 forks source link

Closed Gradlon closed 1 month ago

Gradlon commented 1 month ago

Build scripts and Documentation for docker Swarm CSI.

chrislusf commented 1 month ago

Thanks for this PR! In later PRs, I wonder whether there are some way to add an integration test for this, similar to https://github.com/seaweedfs/seaweedfs/blob/master/.github/workflows/e2e.yml , which can also serve as a usage example.

Gradlon commented 1 month ago

I will delete my fork.

About e2e Test. A real E2E test would mean spinning up a docker swarm cluster. We would maybe need to discuss/you tel me you would go about this.

Thank you for this Project, I am using seaweed in my Cluster, and I am pretty happy with it!

If I can contribute more, I will.

One thing that I see is that the log output of the plugin appears as errors in docker logs. This is not a big issue but also not right ;)

can this be adjusted?

chrislusf commented 1 month ago

A real E2E test would mean spinning up a docker swarm cluster. We would maybe need to discuss/you tel me you would go about this.

Yes. That would be nice. I do not know much here though.

One thing that I see is that the log output of the plugin appears as errors in docker logs. can this be adjusted?

Yes. weed -logtostderr=false ...

blib commented 1 day ago

please note that in docker 27.x.x CSI plugin interface is broken