Closed Gradlon closed 1 month ago
Thanks for this PR! In later PRs, I wonder whether there are some way to add an integration test for this, similar to https://github.com/seaweedfs/seaweedfs/blob/master/.github/workflows/e2e.yml , which can also serve as a usage example.
I will delete my fork.
About e2e Test. A real E2E test would mean spinning up a docker swarm cluster. We would maybe need to discuss/you tel me you would go about this.
Thank you for this Project, I am using seaweed in my Cluster, and I am pretty happy with it!
If I can contribute more, I will.
One thing that I see is that the log output of the plugin appears as errors in docker logs. This is not a big issue but also not right ;)
can this be adjusted?
A real E2E test would mean spinning up a docker swarm cluster. We would maybe need to discuss/you tel me you would go about this.
Yes. That would be nice. I do not know much here though.
One thing that I see is that the log output of the plugin appears as errors in docker logs. can this be adjusted?
Yes. weed -logtostderr=false ...
please note that in docker 27.x.x CSI plugin interface is broken
https://github.com/moby/moby/issues/48133 https://github.com/moby/swarmkit/pull/3181
Build scripts and Documentation for docker Swarm CSI.