Tags in sidebar - Githubissues

h07d0q commented 3 years ago

FeedMe v3.18.3 Release - 215 - 202106110608

Maybe I don't remember correctly, but I think earlier I was able to see the tags in the sidebar. Now I only see the highlighter menu. Has something changed, or am I missing something? Out of an article I can see the tags, but when I select one entry (or when I create a new one) the app closes immediately.

seazon commented 3 years ago

A few versions ago, the highlight name as temporary tag. That is what you see. About the app closes immediately issue, maybe crash issue. Pls send email via FeedMe settings - about - feedback. I can check the error log.

brevilo commented 3 years ago

Hi @seazon,

A few versions ago, the highlight name as temporary tag. That is what you see.

Can you please rephrase that? I don't understand what you're trying to say. I'm having the same issue as @h07d0q which is that one can still assign tags/labels to articles but there's apparently no way to show/list all articles based on the existing tags/labels.

Also, the highlighter feature seems to implement a different use case than tags/labels, no?

Thanks

h07d0q commented 3 years ago

@brevilo when you tap the menu entry "Highlighter" (not expanding it) in the side nav, you will get to the menu where you can add highlights. By adding a new, or editing an existing, you can choose "show in side nav". Then it will act as usual like a tag. You can find and select tagged articles now when you expand the "Highlighter" menu.

@seazon The problem I have (adding new tags to articles) is still remaining with release 217 from 20210912 (I didn't test it with the broken images release before)

brevilo commented 3 years ago

@h07d0q, just to avoid any misunderstanding: tags are defined on the server (e.g. FreshRSS) so it wouldn't make any sense to redefine them separately in the client. Also, FeedMe is clearly aware of them since it allows you to add (server-side) tags to articles, so it should be trivial to show the existing tags in the sidebar for selecting/filtering purposes.

Besides, I had tried to add an already existing tag (identical spelling) to the highlighter feature. Selecting that highlighter tag did not show any articles previously marked with that tag (incl. read/unread).

As far as I can tell tag support is currently broken.

h07d0q commented 3 years ago

That was my opinion too, but seazon responded by mail (after sending a log file) that tags are not synced with the server.

brevilo commented 3 years ago

tags are not synced with the server

Is that considered a bug or a feature? I mean, they are (still) available for assignment to articles, so they are at least fetched from the server at some point.

Also, I just verified that tag creation and assignment still work in FeedMe 3.18.3 (215) and both are synced with the server (FreshRSS 1.18.1). So, at least for me, the only issue is that tags aren't listed anywhere for article selection/filtering.

h07d0q commented 3 years ago

I forgot to mention I am using TT-RSS For me the tags are not available in FeedMe.

I didn't test it in older versions of FeedMe - how can I install them?

brevilo commented 3 years ago

I used to use TT-RSS myself for years but just switched to FreshRSS because of TT-RSS's apparent constraint of supporting the (deprecated?) Fever API only and the resulting lack of (proper) mobile support besides Android. So now I'm trying to find an Android app that properly supports FreshRSS and, unfortunately, there's yet none that works for me without issues. In that sense the TT-RSS Android app was ideal.

I didn't test it in older versions of FeedMe - how can I install them?

The docs say that the highlighter was introduced in 3.17. Presuming that replaced the earlier tag feature you mentioned in your first post, I'd try 3.16 then. Just download and install the APK (probably removing the current one first).

seazon commented 3 years ago

A lot of discussion!

I know now that you are talking about tag. So pls forget the highlighter, that is another feature, not tag.

About tag, yes, now FeedMe supports create and add tag(s) to article and sync, but missing list tags in nav side bar. The reason why FeedMe doesn't support that because tag needs more strategies and considerations to synchronize. FeedMe is not prepared.

About old version, no need to test it since FeedMe never supported that.

brevilo commented 3 years ago

pls forget the highlighter, that is another feature, not tag.

Phew, glad we agree on this 👍

The reason why FeedMe doesn't support that because tag needs more strategies and considerations to synchronize

Not sure what you mean by this. Tagging already works just fine, at least with FreshRSS as the backend. Creating, adding and syncing tags should be the "hard" part (and that works!), not displaying them or using them as a filter. I mean, you already show the existing tags in the tagging dialog, so they are obviosly available to FeedMe. The only thing missing would be showing them in a collapsible "Tags" list in the side bar. Clicking on a tag would show an article list with articles that are tagged with that tag.

Granted, I noticed that the tag assignment dialog also shows the feed category of the current article, next to the tags. Is that part of the problem?

seazon commented 3 years ago

I noticed that the tag assignment dialog also shows the feed category of the current article, next to the tags. Is that part of the problem?

In some RSS services, the category is also a tag.

seazon commented 3 years ago

The reason why FeedMe doesn't support that because tag needs more strategies and considerations to synchronize

When sync tags items?
How to keep tags items consistent with server?

brevilo commented 3 years ago

Do you mean the tags themselves or articles that have certain tags assigned?

If the former: you already fetch them since they are displayed when assigning tags to articles (which works)
If the latter: I would assume that assigned tags are part of the article meta data. That said I'd expect the assigned tags to be synced like any other article meta data update, e.g. the read/unread status.

Which (GR) reference API documentation do you use for the FreshRSS backend?

Jkker commented 2 years ago

Apologies for reviving this ancient thread.

As a TTRSS/FreshRSS user, what I yearn for right now is a tag filter in the sidebar navigator. Tags are quite crucial for our daily use.

As a fellow developer (unfortunately not with Android), my humble suggestion to begin with a basic client-side, read-only display filter for articles that pertain to each tag. Its not that necessary to implement the interaction between tags and categories in my view. In other words, you can treat tags like categories at this point.

This strategy shouldn't conflict with any existing features. Also, TTRSS has tags implemented the same way, so no worries for user experience.

Onwards, you can integrate tags into the search pop-up and implement the logic there. It should be quite similar to the current search feature - removing anything without the selected tags (keywords) from the currently displayed list of articles.

Finally, adding an options in the menu for the user to choose whether each tag (or a custom filter) is displayed in the sidebar like a category will be amazing.

Hope that I can contribute to your project. Feedme is a really amazing app!

Best, Jkker

seazon / FeedMe

Tags in sidebar #348