seb-oss / green

Green is an open-source design system built by SEB.
https://storybook.seb.io/
Apache License 2.0
37 stars 55 forks source link

chore(chlorophyll): change transparentize to color.adjust #1622

Closed patrikfogelstrand closed 1 month ago

patrikfogelstrand commented 1 month ago

Our Rspack build gave warnings that we were using deprecated features from Chlorophyll:

WARNING in ./src/components/spinner/spinner.scss (../../../node_modules/css-loader/dist/cjs.js!../../../node_modules/sass-loader/dist/cjs.js!./src/components/spinner/spinner.scss)
  ⚠ ModuleWarning: Deprecation Warning on line 313, column 20 of file:///<REPO>/node_modules/@sebgroup/chlorophyll/scss/tokens/_shame.scss:313:20:
  │ transparentize() is deprecated. Suggestions:
  │
  │ color.scale($color, $alpha: -83%)
  │ color.adjust($color, $alpha: -0.83)
  │
  │ More info: https://sass-lang.com/d/color-functions
  │
  │ 313 |   --border-color: #{transparentize($black, 0.83)}; // #CECECE against white

This should get rid of these warnings.

I don't know how to test this, would be appreciated if you could verify that the output is the same.

green-design-system-bot[bot] commented 1 month ago

🦋 Changeset status

Based on the included changeset, the following releases will be published as a result of this PR:

Note: If unpublished changesets where merged to main after the first commit of this PR, this list will include those changes in addition to the ones specific to this PR.

green-design-system-bot[bot] commented 1 month ago

👋 Thanks for creating a pull request!

🚀 Checkout the storybooks we've created for it: