grid gap fix - Githubissues

vsjolander commented 1 month ago

This pull request includes changes to the @sebgroup/green-core package and the GdsGrid component to align with the CSS specification for the gap property. The most important changes include updating the gap property handling and modifying the GdsGrid component to switch the order of row and column values.

Modifications to GdsGrid component:

libs/core/src/components/layout/grid/grid.ts: Changed the styleTemplate function to switch the order of rowGap and colGap values to align with the CSS specification. ([libs/core/src/components/layout/grid/grid.tsL46-R47](diffhunk://#diff-1afc0b4bc6a6dc96b354526bfd9f753b3727e8d75ce5ddeb2b6c5d52e4918ad5L46-R47))

green-design-system-bot[bot] commented 1 month ago

🦋 Changeset status

Based on the included changeset, the following releases will be published as a result of this PR:

@sebgroup/green-core: 1.43.3 → 1.43.4 (patch bump)

Note: If unpublished changesets where merged to main after the first commit of this PR, this list will include those changes in addition to the ones specific to this PR.

green-design-system-bot[bot] commented 1 month ago

👋 Thanks for creating a pull request!

🚀 Checkout the storybooks we've created for it:

seb-oss / green

grid gap fix #1633

🦋 Changeset status