search

seb-oss / green

Green is an open-source design system built by SEB.
https://storybook.seb.io/
Apache License 2.0
38 stars 50 forks source link

Pagination: Moves position #790

Open Maximilian-R opened 1 year ago

Maximilian-R commented 1 year ago

Tested it out and noticed some issues:

Issue 1

When on page 1 and clicking on next arrow, the prev-arrow is added and push the buttons so if I click again w/o moving mouse I go to last page.

Screenshot 2023-03-02 at 12 39 04 Screenshot 2023-03-02 at 12 39 08

Maybe arrows should always keep it's space?

The dots are also changing right arrow position, but maybe not a problem.

Issue 2

Doesn't seem to work with keyboard navigation (Enter or Space) to select pages or prev/next

Originally posted by @vsjolander in https://github.com/sebgroup/green/pull/735#pullrequestreview-1321664359

EldRoos commented 1 month ago

I agree it is troublesome that it changes position and width depending on what is selected.

Looks like enter now works (but not space).