seb-oss / vanilla-pattern-library

https://sebgroup.github.io/vanilla-pattern-library/
Apache License 2.0
9 stars 10 forks source link

Fix missing font awesome resources #241

Open AdamPirany opened 3 years ago

AdamPirany commented 3 years ago

I try to implement the modal fold-out component https://designlibrary.sebank.se/components/component-foldout

but it seems to be missing in the modal component. Any idea when this can be done ?

Regards

splashdust commented 3 years ago

Here it is: https://sebgroup.github.io/vanilla-pattern-library/#components/modals/modal-foldout

There seem to be an issue with Font Awesome icons at the moment, so you need to click on "Show details" and select "Expanded state" to see it (because base state only shows the ellipsis icon)

One thing to note is that the fold-out is not implemented as a separate component here, but instead uses the drop down component. Thus it doesn't have its own class name.

Maximilian-R commented 3 years ago

The font awesome resources in preview mode are pointing to https://designlibrary.sebgroup.com/static/Fonts/fontawesome/* which is empty. Perhaps the resources was removed along with the launch of the new DL site (that uses the font awesome npm package instead)? Should we include them in this project? Should we make us of a cdn instead, like the bootstrap project? Lets discuss after holidays! 😄