search

seb-vial / grav-plugin-about-me

Simple plugin to show some information about yourself, with a nice picture, your name, your title/job and a description
MIT License
9 stars 7 forks source link

Empty 'Title' not possible #13

Closed metbril closed 5 years ago

metbril commented 5 years ago

I don't like a job title in the about me page of my personal website. So I'd like to leave it empty. However, saving an empty value in the admin panel will show the plugin default for Santa.

A workaround is to save a space character which shows up empty. But this renders a <h3> section with the space.

Since reverting to the plugin default is standard Grav behaviour, I think the only option to really suppress the job title would be to create a toggle for this. If you allow a PR for this, I will submit one.

seb-vial commented 5 years ago

In deed I suppose a toggle would be the right option here. If you have time to make a PR, that's great, I'll merge it whenever I can, thank you.

metbril commented 5 years ago

I will submit a PR in the coming day(s). You could wait with a new release and include this as well.

seb-vial commented 5 years ago

Thank you. My thought exactly ;)

metbril commented 5 years ago

That was not too difficult. I just love Grav.