search

sebaslogen / resaca

Compose Multiplatform library to scope ViewModels to a Composable, surviving configuration changes and navigation
MIT License
392 stars 9 forks source link

Simple Kotlin DSL Property Assignment #127

Closed niyajali closed 1 month ago

niyajali commented 1 month ago

https://blog.gradle.org/simpler-kotlin-dsl-property-assignment

niyajali commented 1 month ago

Can We Enable KLib ABI validation https://github.com/Kotlin/binary-compatibility-validator?tab=readme-ov-file#experimental-klib-abi-validation-support

sebaslogen commented 1 month ago

Awesome, thanks for the contribution, I had no idea of this Gradle improvement! I also like the Klib validation, I'll add it to the backlog, but if you wanna open another PR, you're very welcome!

niyajali commented 1 month ago

I would like to but i don't have macOS for multiplatform for that i'm unable to dump klib api if you have than please apply klib validation inside apiValidation block

@OptIn(kotlinx.validation.ExperimentalBCVApi::class)
klib {
        enabled = true
    }

and dumb klib validation using apiDump command and it will generate klib api which is use for verification

sebaslogen commented 1 month ago

I would like to but i don't have macOS for multiplatform for that i'm unable to dump klib api if you have than please apply klib validation inside apiValidation block

@OptIn(kotlinx.validation.ExperimentalBCVApi::class)
klib {
        enabled = true
    }

and dumb klib validation using apiDump command and it will generate klib api which is use for verification

No problem, I'll add it soon. Thanks again!

sebaslogen commented 1 month ago

Done! https://github.com/sebaslogen/resaca/commit/ee93b12e338b92b177d8c302782b389bd858509b